[sforbes]

Hey,

Yesterday I noticed that after moving from 1.12.3-102 to 1.12.4-101 that any email attchments weren’t being processed properly and they’d end up with a length of 0 (we’re using S3 to store our attachments).<br />
Checking upstream I noticed that 1.12.5 was released about 5 days ago and even though the release and commit messages for the changes is pretty poor I saw that the three changes that were made were all related to file handling, so I’ve applied those three changes to our 1.12.4-101 instance and it appears to have resolved the file upload issue for us.

So I just wanted to let you know that there is an important upstream fix available.

Thanks, Shaun

[lafr]

Here is how we fixed it:

change one line in include/class.mailfetch.php

line: 834

change
$file['dataclb'] = function() use ($self, $mid, $a) {
to
$file['data'] = function() use ($self, $mid, $a) {

[sforbes]

Looks similar to what was done in 1.12.5, along with a couple of other related classes

https://github.com/osTicket/osTicket/commit/d3e643d9d27cea6b1cfeadcf49403d7d14d1d4da

 

[stevland]

Thank you very much for contributing your observations and fixes here, guys. 

I do have a 1.12.5 release available now, and am currently in the testing phase for a 1.14.1 release as well.