[Resolved] Upstream 1.12.5 release – fixes zero length attachments

To Parent Forum
    • November 25, 2019 at 3:34 pm #5320
      S
      sforbes
      Participant

      Hey,

      Yesterday I noticed that after moving from 1.12.3-102 to 1.12.4-101 that any email attchments weren’t being processed properly and they’d end up with a length of 0 (we’re using S3 to store our attachments).<br />
      Checking upstream I noticed that 1.12.5 was released about 5 days ago and even though the release and commit messages for the changes is pretty poor I saw that the three changes that were made were all related to file handling, so I’ve applied those three changes to our 1.12.4-101 instance and it appears to have resolved the file upload issue for us.

      So I just wanted to let you know that there is an important upstream fix available.

      Thanks, Shaun

    • November 26, 2019 at 1:44 am #5321
      L
      lafr
      Participant

      Here is how we fixed it:

      change one line in include/class.mailfetch.php

      line: 834

      change
      $file['dataclb'] = function() use ($self, $mid, $a) {
      to
      $file['data'] = function() use ($self, $mid, $a) {

    • November 26, 2019 at 2:23 pm #5323
      S
      sforbes
      Participant

      Looks similar to what was done in 1.12.5, along with a couple of other related classes

      https://github.com/osTicket/osTicket/commit/d3e643d9d27cea6b1cfeadcf49403d7d14d1d4da

       

    • November 28, 2019 at 3:26 pm #5339
      stevland
      Keymaster

      Thank you very much for contributing your observations and fixes here, guys. 

      I do have a 1.12.5 release available now, and am currently in the testing phase for a 1.14.1 release as well.

You must be logged in to reply to this topic.